On 11/07/2023 14:18, Konrad Dybcio wrote: > In order to (at least partially) untangle the global BCM voter lookup > (as again, they are shared throughout the entire system and not bound to > individual buses/providers), introduce a new required property to assign > a unique identifier to each BCM voter. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > --- > .../devicetree/bindings/interconnect/qcom,bcm-voter.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml b/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml > index eec987640b37..09321c1918bf 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml > @@ -38,8 +38,14 @@ properties: > > $ref: /schemas/types.yaml#/definitions/uint32 > > + qcom,bcm-voter-idx: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: > + A globally unique predefined discrimnator, identifying each BCM voter. s/each/this/ ? If I understand correctly, there might be more than one instance. The problem is that I cannot find such case in upstream sources. > + > required: > - compatible > + - qcom,bcm-voter-idx This should not be really required, because it affects the ABI. You also need to fix the reported warning. Best regards, Krzysztof
