On Mon, 19 Jun 2023 22:37:43 +0200, Jakob Hauser wrote:
> For the regulators, apply the same settings as in the downstream
> devicetree [1], including the "regulator-always-on" for the SAFE_LDO.
> For the voltage of SAFE_LDO, however, there is only one voltage of 4.9 V
> available in the mainline driver [2][3].
>
> The values of the battery data evolve from following sources:
> - precharge current: 450 mA corresponds to the default value of the chip. It
> doesn't get changed by the downstream Android driver. Therefore let's stick
> to this value.
> - constant charge current: The 1000 mA are taken from the downstream devicetree
> of the serranove battery. It's not easy to spot. The value is in the line
> "input_current_limit" [4]. The rows are according to the power supply type,
> the 4th value stands for "main supply" [5]. That's the value used by the
> Android driver when a charging cable is plugged into the device.
> - charge termination current: In the downstream devicetree of the battery
> that's the line "full_check_current_1st", which contains the 150 mA [6].
> - precharge voltage: This one doesn't get set in the downstream Android driver.
> The chip's default is 2.8 V. That seemed too low to have a notable effect of
> handling the battery gentle. The chosen value of 3.5 V is a bit arbitrary
> and possibly rather high. As the device is already several years old and
> therefore most batteries too, a value on the safe side seems reasonable.
> - constant charge voltage: The value of 4.35 V is set in the line
> "chg_float_voltage" of the downstream battery devicetree [7].
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: msm8916-samsung-serranove: Add RT5033 PMIC with charger
commit: 404d7f65767dde3a0eb3d6127b458b61ed7d7118
Best regards,
--
Bjorn Andersson <andersson@xxxxxxxxxx>
