On 8.07.2023 16:29, Jonathan Cameron wrote: > On Tue, 27 Jun 2023 03:08:20 +0300 > Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > >> On 27/06/2023 02:21, Konrad Dybcio wrote: >>> Even though it existed in bindings for the longest time, >>> ADC5_GPIO2_100K_PU was never assigned in the driver. Do so. >>> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >>> --- >>> drivers/iio/adc/qcom-spmi-adc5.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >> >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> >> > I was a little unsure on this one. So far I've applied it as a 'feature' > so it's in the normal iio togreg branch, but perhaps it should be a fix? I suppose it's a feature as it's never been used before Konrad > > For now applied to the togreg branch of iio.git but given I'll be rebasing > that on rc1, for now it's only visible as testing. 0-day can play with that > in the meantime and see if it can find any issues > > Jonathan > >