On 6.07.2023 23:10, Rob Clark wrote: > From: Rob Clark <robdclark@xxxxxxxxxxxx> > > All of these are derivatives of a630. > > Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 7 ++++--- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > index 5deb79924897..f1bb20574018 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > @@ -1617,7 +1617,7 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node) > SZ_256K - SZ_16K, 0x44000, "dcache"); > if (ret) > goto err_memory; > - } else if (adreno_is_a630(adreno_gpu) || adreno_is_a615_family(adreno_gpu)) { > + } else if (adreno_is_a630_family(adreno_gpu)) { > /* HFI v1, has sptprac */ > gmu->legacy = true; > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h > index 994ac26ce731..6066cfaaea52 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h > @@ -335,10 +335,11 @@ static inline int adreno_is_a690(const struct adreno_gpu *gpu) > /* The order of args is important here to handle ANY_ID correctly */ > return adreno_cmp_rev(ADRENO_REV(6, 9, 0, ANY_ID), gpu->rev); > }; > -/* check for a615, a616, a618, a619 or any derivatives */ > -static inline int adreno_is_a615_family(const struct adreno_gpu *gpu) > +/* check for a615, a616, a618, a619 or any a630 derivatives */ > +static inline int adreno_is_a630_family(const struct adreno_gpu *gpu) > { > - return adreno_is_revn(gpu, 615) || > + return adreno_is_revn(gpu, 630) || > + adreno_is_revn(gpu, 615) || > adreno_is_revn(gpu, 616) || > adreno_is_revn(gpu, 618) || > adreno_is_revn(gpu, 619);