On Tue, Jul 28, 2015 at 8:06 PM, Tim Bird <tim.bird@xxxxxxxxxxxxxx> wrote: > Antoine and Rob, > > I was just doing some testing with USB on a Qualcomm SoC. > > I followed the instructions in the binding document: > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > > which has a compatible for "qcom,ci-hdrc", and is, in general, > for chipidea-based USB controllers. > > It says in the document that the property usb-phy is deprecated, and to > use phys and phy-names instead. However, the Qualcomm > driver for this still uses usb-phy. That driver is in: > drivers/usb/chipidea/ci_hdrc_msm.c Deprecated means it still exists in the wild and should be maintained, but don't use it for new dts files. > I'm guessing I should update the Qualcomm driver to use > phys and phy-names, but wanted to check with you-all to > verify that this is the preferred method of getting > phys by phandle now. It's either change the driver > or make an exception in the binding document, I believe. That would be fine along with updating the dts files, but the doc should remain for some time. > I presume I should be changing devm_usb_get_phy_by_phandle() > to of_phy_get(), but let me know if there's more to qit than that. devm_phy_get actually. The driver already supports it. See ci_hdrc_probe in core.c. > In case I change the driver, do I then update the binding doc > to remove the information about the deprecated property, or not? Not. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
