On Fri, 30 Jun 2023 at 11:13, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>
> On 30.06.2023 08:13, Dmitry Baryshkov wrote:
> > The commit b2de43136058 ("arm64: dts: qcom: pmk8350: Add peripherals for
> > pmk8350") for the ADC TM (thermal monitoring device) have used the
> > compatible string from the vendor kernel ("qcom,adc-tm7"). Use the
> > proper compatible string that is defined in the upstream kernel
> > ("qcom,spmi-adc-tm5-gen2").
> >
> > Fixes: b2de43136058 ("arm64: dts: qcom: pmk8350: Add peripherals for pmk8350")
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> Well actually, adc-tm7 would be the correct compatible (PM8350X is PMIC7)
> but it never landed on the driver side..
I also thought so (and started implementing adc-tm7), but then I
stumbled upon the commit 96f6f333bcf0 ("thermal/drivers/qcom: Add
support for PMIC5 Gen2 ADCTM"), which clearly tells:
Add support for PMIC5 Gen2 ADC_TM, used on PMIC7 chips. It is a
close counterpart of PMIC7 ADC and has the same functionality as
PMIC5 ADC_TM, for threshold monitoring and interrupt generation.
It is present on PMK8350 alone, ....
So, this is the right compatible for PMK8350.
>
> Konrad
> > arch/arm64/boot/dts/qcom/pmk8350.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pmk8350.dtsi b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
> > index bc6297e7253e..1eb74017062d 100644
> > --- a/arch/arm64/boot/dts/qcom/pmk8350.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pmk8350.dtsi
> > @@ -59,7 +59,7 @@ pmk8350_vadc: adc@3100 {
> > };
> >
> > pmk8350_adc_tm: adc-tm@3400 {
> > - compatible = "qcom,adc-tm7";
> > + compatible = "qcom,spmi-adc-tm5-gen2";
> > reg = <0x3400>;
> > interrupts = <PMK8350_SID 0x34 0x0 IRQ_TYPE_EDGE_RISING>;
> > #address-cells = <1>;
--
With best wishes
Dmitry
