On Tue, Mar 07, 2023 at 05:51:35PM +0200, Dmitry Baryshkov wrote: > On 05/03/2023 04:21, Maximilian Luz wrote: > > +static struct qcuefi_client *qcuefi_acquire(void) > > Doesn't this need the __locks annotation? No, the mutex implementation does not use sparse annotation so adding __acquires() here will instead introduce new warnings. > > +{ > > + mutex_lock(&__qcuefi_lock); > > + return __qcuefi; > > +} Johan