On Wed, 28 Jun 2023 at 22:40, Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Wed, Jun 28, 2023 at 10:33:16PM +0300, Dmitry Baryshkov wrote: > > On 28/06/2023 21:10, Mark Brown wrote: > > > > If the goal here is to put all the firmwares for a given board in a > > > single place surely it would be better to factor this all out of the > > > individual drivers so that they ask some helper for a directory to use > > > for firmware? Adding these device specific firmware node properties > > > doesn't seem to follow. > > > This quickly becomes overcomplicated. Some platforms use different firmware > > naming structure. Some firmware goes into a generic location and other files > > go into device-specific location. So having a generic helper doesn't really > > help. > > That sounds like a job for symlinks surely? Excuse me, but I don't understand the goal for such symlinks. In my opinion (and more importantly, in the opinion of qcom maintainers), firmware-name does the necessary job. It provides enough flexibility and doesn't require any additional dances around. -- With best wishes Dmitry