Hi Mani
Regarding [PATCH v4] submission for review, I would like to confirm with you whether there are any defects that need to be corrected?
辛安文 Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd.
Mobile: +86-15375456183 | Email : Duke.xin@xxxxxxxxxxx | Tel: +86-0551-65869386-8632
Website: www.quectel.com | QQ: 602659072 | Wechat: 15375456183
Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China
安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼 200233
-----邮件原件-----
发件人: Duke Xin(辛安文)
发送时间: 2023年6月12日 10:02
收件人: Manivannan Sadhasivam <mani@xxxxxxxxxx>; Duke Xin(辛安文) <duke_xinanwen@xxxxxxx>
抄送: loic.poulain@xxxxxxxxxx; slark_xiao@xxxxxxx; fabio.porcedda@xxxxxxxxx; koen.vandeputte@xxxxxxxxxxxx; song.fc@xxxxxxxxx; bhelgaas@xxxxxxxxxx; mhi@xxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; Jerry Meng(蒙杰) <jerry.meng@xxxxxxxxxxx>
主题: 回复: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
Hi Mani
Ok. Previously I used to see same modules having two different IDs because they share different baseline (from qcom). I will amend the commit message accordingly.
For future patches, please include these info in the commit message.
>> Got it. In the future patch, I will add the corresponding supplementary information (such as baseline) to make a difference.
Thank you very much for your patient review again.
辛安文 Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd.
Mobile: +86-15375456183 | Email : Duke.xin@xxxxxxxxxxx | Tel: +86-0551-65869386-8632
Website: www.quectel.com | QQ: 602659072 | Wechat: 15375456183
Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China
安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼 200233
-----邮件原件-----
发件人: Manivannan Sadhasivam <mani@xxxxxxxxxx>
发送时间: 2023年6月9日 23:38
收件人: Duke Xin(辛安文) <duke_xinanwen@xxxxxxx>
抄送: loic.poulain@xxxxxxxxxx; slark_xiao@xxxxxxx; fabio.porcedda@xxxxxxxxx; koen.vandeputte@xxxxxxxxxxxx; song.fc@xxxxxxxxx; bhelgaas@xxxxxxxxxx; mhi@xxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; Jerry Meng(蒙杰) <jerry.meng@xxxxxxxxxxx>; Duke Xin(辛安文) <duke.xin@xxxxxxxxxxx>
主题: Re: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
On Thu, Jun 08, 2023 at 02:29:27AM -0700, Duke Xin(辛安文) wrote:
> The product's would use the same config as previous EM160R-GL
>
> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@xxxxxxx>
Modified the commit message and subject to reflect the usecase and applied to mhi-next!
- Mani
> Reviewed-by: Manivannan Sadhasivam <mani@xxxxxxxxxx>
> ---
> Changelog
>
> v3 -> v4
>
> * Update commit message to include the changelog and reviewd tag.
>
> v2 -> v3
>
> * Add patch CC to mhi@xxxxxxxxxxxxxxx.
>
> v1 -> v2
>
> * Remove Space before */ and "for laptop" description.
> ---
> drivers/bus/mhi/host/pci_generic.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c
> b/drivers/bus/mhi/host/pci_generic.c
> index 70e37c490150..5f204b819e95 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -591,6 +591,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + /* EM160R-GL (sdx24) */
> + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d),
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
