On Mon, Jun 19, 2023 at 11:17 PM Matthias Brugger
<matthias.bgg@xxxxxxxxx> wrote:
>
>
>
> On 13/06/2023 13:49, Yangtao Li wrote:
> > From: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
> >
> > Register thermal zones as hwmon sensors to let userspace read
> > temperatures using standard hwmon interface.
> >
> > Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
> > [Yangtao change to use dev_warn and remove return]
> > Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
> > ---
> > drivers/thermal/thermal-generic-adc.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c
> > index 017b0ce52122..9531bc2f2ce7 100644
> > --- a/drivers/thermal/thermal-generic-adc.c
> > +++ b/drivers/thermal/thermal-generic-adc.c
> > @@ -13,6 +13,8 @@
> > #include <linux/slab.h>
> > #include <linux/thermal.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> > struct gadc_thermal_info {
> > struct device *dev;
> > struct thermal_zone_device *tz_dev;
> > @@ -153,6 +155,9 @@ static int gadc_thermal_probe(struct platform_device *pdev)
> > return ret;
> > }
> >
> > + if (devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev))
> > + dev_warn(&pdev->dev, "Failed to add hwmon sysfs attributes\n");
>
> Isn't that already done by patch 1/12?
I think patch 12 should just be squashed in?
> Regards,
> Matthias
>
> > +
> > return 0;
> > }
> >
