Hi, On Wed, Jun 14, 2023 at 4:28 AM Vijaya Krishna Nivarthi <quic_vnivarth@xxxxxxxxxxx> wrote: > > The select_fifo/dma_mode() functions in geni driver enable/disable > interrupts (secondary included) conditionally for non-uart modes, while > uart is supposed to manage this internally. > However, only uart uses secondary IRQs while spi, i2c do not care about > these at all making their enablement (or disablement) totally unnecessary > for these protos. > Similarly, select_gpi_mode() also does disable s_irq and its useless again. > > Drop enabling/disabling secondary IRQs. > This doesn't solve any observed problem but only gets rid of code pieces > that are not required. > > Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@xxxxxxxxxxx> > --- > v1 -> v2: > - apply similar changes to select_gpi_mode() > - modified commit message accordingly > --- > drivers/soc/qcom/qcom-geni-se.c | 28 ++++------------------------ > 1 file changed, 4 insertions(+), 24 deletions(-) Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
