On Fri, Jun 09, 2023 at 05:22:00PM +0530, Krishna Chaitanya Chundru wrote: > On 6/7/2023 10:13 PM, Bjorn Helgaas wrote: > > On Wed, Jun 07, 2023 at 09:48:07PM +0530, Krishna chaitanya chundru wrote: > > > Add support to vote for ICC bandwidth based on the link > > > speed and width. > > This plus the pcie_ep->icc init below is basically identical to > > qcom_pcie_icc_init() in pcie_qcom.c. Why not use the same structure > > here, with a qcom_pcie_icc_init() function? It's better to be the > > same than different (when possible, of course). > > In pcie_qcom.c driver the resources will be turned on the probe itself. > > But in pcie-qcom-ep.c driver will wait for the host to toggle the perst to > enable all the resources > > that is reason it is different here. Understood, differences like this do make sense. It's not always possible, but when it is, it's helpful to use similar structure and function names because it makes it easier to understand and easier to see opportunities for refactoring. Bjorn
