[+cc Yang Li, sorry I didn't notice your patch earlier: https://lore.kernel.org/r/20230607093514.104012-1-yang.lee@xxxxxxxxxxxxxxxxx] I think we can squash this into the original commit since it hasn't gone upstream yet. Also note that removing the dev_err() apparently makes "dev" unused, so we'd have to remove that as well, based on this report [2]. [2] https://lore.kernel.org/r/202306080418.i64hTj5T-lkp@xxxxxxxxx On Wed, Jun 07, 2023 at 03:49:25PM -0500, Bjorn Helgaas wrote: > On Fri, Jun 02, 2023 at 05:17:55PM +0530, Manivannan Sadhasivam wrote: > > Add PCI Endpoint driver for the Qualcomm MHI (Modem Host Interface) bus. > > The driver implements the MHI function over PCI in the endpoint device > > such as SDX55 modem. The MHI endpoint function driver acts as a > > controller driver for the MHI Endpoint stack and carries out all PCI > > related activities like mapping the host memory using iATU, triggering > > MSIs etc... > > ... > > > +static int pci_epf_mhi_bind(struct pci_epf *epf) > > +{ > > ... > > > + ret = platform_get_irq_byname(pdev, "doorbell"); > > + if (ret < 0) { > > + dev_err(dev, "Failed to get Doorbell IRQ\n"); > > This dev_err() causes this new warning from the 0-day robot [1]: > > drivers/pci/endpoint/functions/pci-epf-mhi.c:362:2-9: line 362 is redundant because platform_get_irq() already prints an error > > Maybe we could drop it? > > Bjorn > > [1] https://lore.kernel.org/all/20230607163937.ZTc-D%25lkp@xxxxxxxxx/
