On 07/06/2023 18:30, Ekansh Gupta wrote: > Add "qcom,fastrpc-gids" property to the list of optional properties. > This property contains the list of privileged group IDs which is > used to offload process to remote subsystem with increased privileges. Why or when anyone would use this property? > > Signed-off-by: Ekansh Gupta <quic_ekangupt@xxxxxxxxxxx> > --- > Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > index 1ab9588..2a2124f 100644 > --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > @@ -57,6 +57,11 @@ properties: > Virtual machine IDs for remote processor. > $ref: "/schemas/types.yaml#/definitions/uint32-array" > > + qcom,fastrpc-gids: > + description: > + Group IDs for fastrpc. You just pasted here property name. It does not help me to understand what's this. Explain in description. > + $ref: "/schemas/types.yaml#/definitions/uint32-array" Drop quotes. missing min/maxItems. > + > "#address-cells": > const: 1 > > @@ -120,6 +125,7 @@ examples: > qcom,glink-channels = "fastrpcglink-apps-dsp"; > label = "sdsp"; > qcom,non-secure-domain; > + qcom,fastrpc-gids = <2908> Eh, what does 2908 stands for? Why not 3012 or 1842? How anyone can figure this out? Best regards, Krzysztof
