On 07/06/2023 12:56, Varadarajan Narayanan wrote:
> Add USB phy and controller nodes
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 55 +++++++++++++++++++++++++++++++++++
> 1 file changed, 55 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index c2d6cc65..3183357 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -383,6 +383,61 @@
> status = "disabled";
> };
> };
> +
> + usb_0_m31phy: hs_m31phy@7b000 {
Node names should be generic. See also explanation and list of examples
in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "qcom,ipq5332-m31-usb-hsphy";
> + reg = <0x0007b000 0x12C>,
> + <0x08af8800 0x400>;
Lowercase hex only.
> + reg-names = "m31usb_phy_base",
> + "qscratch_base";
> + phy_type= "utmi";
> +
> + resets = <&gcc GCC_QUSB2_0_PHY_BCR>;
> + reset-names = "usb2_phy_reset";
> +
> + status = "okay";
It's by default. Drop.
> + };
> +
> + usb2: usb2@8a00000 {
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Node names should be generic. See also explanation and list of examples
in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "qcom,ipq5332-dwc3", "qcom,dwc3";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + reg = <0x08af8800 0x100>;
reg is always after compatible. Ranges is third. Then you will spot that
address is wrong.
> +
> + clocks = <&gcc GCC_USB0_MASTER_CLK>,
> + <&gcc GCC_SNOC_USB_CLK>,
> + <&gcc GCC_USB0_SLEEP_CLK>,
> + <&gcc GCC_USB0_MOCK_UTMI_CLK>;
Fix alignment.
> +
> + clock-names = "core",
> + "iface",
> + "sleep",
> + "mock_utmi";
Fix alignment.
> +
> + interrupts-extended = <&intc GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "pwr_event";
> +
Best regards,
Krzysztof
