On 2.06.2023 13:03, Varadarajan Narayanan wrote: > IPQ9574 has a tsens v2.3.1 peripheral which monitors temperatures > around the various subsystems on the die. > > Co-developed-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> > --- > [v5]: > Incorporate review comments "fix bug" is too vague.. > > [v2]: > Add "qcom,ipq8074-tsens" as fallback compatible > --- > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > index 0baeb10..cda3fd4 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > @@ -206,6 +206,16 @@ > #size-cells = <1>; > }; > > + tsens: thermal-sensor@4a9000 { > + compatible = "qcom,ipq9574-tsens", "qcom,ipq8074-tsens"; > + reg = <0x004a9000 0x1000>, /* TM */ > + <0x004a8000 0x1000>; /* SROT */ The comments are unnecessary, we've been copypasting them from SoC to SoC but it's time we stop. With that: Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad > + interrupts = <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "combined"; > + #qcom,sensors = <16>; > + #thermal-sensor-cells = <1>; > + }; > + > tlmm: pinctrl@1000000 { > compatible = "qcom,ipq9574-tlmm"; > reg = <0x01000000 0x300000>;