Hi Bryan,
Thanks for your review!
On 5/26/2023 9:27 PM, Bryan O'Donoghue wrote:
On 26/05/2023 16:54, Bryan O'Donoghue wrote:
On 25/05/2023 18:21, Jagadeesh Kona wrote:
Fixes: 260e36606a03 ("clk: qcom: clk-alpha-pll: add Lucid EVO PLL
configuration interfaces")
Is this a "Fixes" without the previous patch to stuff the CAL_L_VAL
and VAL_L fields ?
[PATCH V2 3/6] clk: qcom: clk-alpha-pll: Remove explicit CAL_L
configuration for EVO PLL
Surely you need _both_ with this patch depending on the previous, per
your comment ?
- .l = 0x3e,
+ /* .l includes CAL_L_VAL, L_VAL fields */
+ .l = 0x0044003e,
---
bod
i.e. if you pick up this patch on its own you won't populate
CAL_L_VAL... right ?
It would make more sense to squash the two patches.
Sure, will squash both the patches in next series.
---
bod
Thanks & Regards,
Jagadeesh
