On 31/05/2023 03:42, Dmitry Baryshkov wrote: > On PM8941 pon doesn't store the reset reason. However we still need the > wrapping node for pwrkey and resin nodes. Add bindings for pm8941-pon > device. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > --- > .../devicetree/bindings/power/reset/qcom,pon.yaml | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > index d96170eecbd2..eb3c88e501ef 100644 > --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml > @@ -19,6 +19,7 @@ properties: > compatible: > enum: > - qcom,pm8916-pon > + - qcom,pm8941-pon > - qcom,pms405-pon > - qcom,pm8998-pon > - qcom,pmk8350-pon > @@ -56,13 +57,22 @@ required: > unevaluatedProperties: false > > allOf: > - - $ref: reboot-mode.yaml# > + - if: > + not: > + properties: > + compatible: > + contains: > + const: qcom,pm8941-pon > + then: > + $ref: reboot-mode.yaml# Are you sure that this works, so pm8941 does not allow mode-* properties? I am afraid they would still be considered evaluated, thus your if-not is not effective. Best regards, Krzysztof
