On 5/30/23 1:36 PM, Bert Karwatzki wrote:
Am Dienstag, dem 30.05.2023 um 07:29 -0500 schrieb Alex Elder:
On 5/30/23 4:10 AM, Bert Karwatzki wrote:
Am Dienstag, dem 30.05.2023 um 09:09 +0200 schrieb Simon Horman:
On Sat, May 27, 2023 at 10:46:25PM +0200, Bert Karwatzki wrote:
commit b8dc7d0eea5a7709bb534f1b3ca70d2d7de0b42c introduced
IPA_STATUS_SIZE as a replacement for the size of the removed struct
ipa_status. sizeof(struct ipa_status) was sizeof(__le32[8]), use this
as IPA_STATUS_SIZE.
This is better, however it really isn't done in a way that's
appropriate for a Linux kernel patch. I will gladly help you
get it right if you have the patience for that. But I'm not
going to say anything yet--until you say you want me to help
you do this. If you prefer, I can submit the patch for you.
The reason this is important is your commit is permanent, and
just like code, commit messages are best if kept consistent
and readable. I also am offering to help you understand so
you avoid any trouble next time you want to send a kernel patch.
Let me know what you prefer.
-Alex
So here's v3 of the patch, done (I hope) in a way that is more standard
conforming.
From e0dc802b5f6f41c0a388c7281aabe077a4e3c5a2 Mon Sep 17 00:00:00 2001
From: Bert Karwatzki <spasswolf@xxxxxx>
Date: Tue, 30 May 2023 20:23:29 +0200
Subject: [PATCH] net/ipa: Use correct value for IPA_STATUS_SIZE
IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement
for the size of the removed struct ipa_status which had size
sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.
Signed-off-by: Bert Karwatzki <spasswolf@xxxxxx>
This is better, but there are a few more things to do differently.
- When re-submitting a patch, please indicate a (new) version in
the subject line. Since you haven't been doing that, it should
be sufficient to just use "version 2", something like this:
[PATCH net v2] net: ipa: Use the correct value for IPA_STATUS_SIZE
- Add a "Fixes" tag above your "Signed-off-by:" line:
Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")
- Do not send information above the patch in the e-mail. An easy
way to get it right is to use "git send-email". For example:
- git format-patch -1
- Edit 0001-*.patch, adding lines like this below the "From:" line:
To: davem@xxxxxxxxxxxxx
To: edumazet@xxxxxxxxxx
To: kuba@xxxxxxxxxx
To: pabeni@xxxxxxxxxx
Cc: elder@xxxxxxxxxx
Cc: netdev@xxxxxxxxxxxxxxx
Cc: linux-arm-msm@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
- Run this:
git send-email --dry-run 0001-*.patch
to try to catch any errors
- Finally, run this:
git send-email 0001-*.patch
to actually send the patch. This will require a password.
Even if you don't use "git send-email", just let the e-mail
itself indicate the "From:" and "Subject:" lines. And have
the content of the e-mail be the patch itself.
I hope this helps.
-Alex
---
drivers/net/ipa/ipa_endpoint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c
index 2ee80ed140b7..afa1d56d9095 100644
--- a/drivers/net/ipa/ipa_endpoint.c
+++ b/drivers/net/ipa/ipa_endpoint.c
@@ -119,7 +119,7 @@ enum ipa_status_field_id {
};
/* Size in bytes of an IPA packet status structure */
-#define IPA_STATUS_SIZE sizeof(__le32[4])
+#define IPA_STATUS_SIZE sizeof(__le32[8])
/* IPA status structure decoder; looks up field values for a structure */
static u32 ipa_status_extract(struct ipa *ipa, const void *data,
