Re: [PATCH v6 2/5] pinctrl: qcom: Use qcom_scm_io_update_field()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Wed, Mar 29, 2023 at 01:16:49PM +0530, Mukesh Ojha kirjoitti:
> Use qcom_scm_io_update_field() exported function introduced
> in last commit.


>  	u32 val;
> +	u32 mask;

Swapping their order may help with readability.


> +	mask = (7 << g->intr_target_bit);

Why not GENMASK(2, 0) at the same time?

With Best Regards,
Andy Shevchenko

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux