Wed, Mar 29, 2023 at 01:16:49PM +0530, Mukesh Ojha kirjoitti: > Use qcom_scm_io_update_field() exported function introduced > in last commit. ... > u32 val; > + u32 mask; Swapping their order may help with readability. ... > + mask = (7 << g->intr_target_bit); Why not GENMASK(2, 0) at the same time? -- With Best Regards, Andy Shevchenko
