On Thu, 25 May 2023 at 23:18, Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> wrote: > > On 2023-05-24 15:38:23, Jessica Zhang wrote: > <snip> > > >> + WARN_ON_ONCE(vdsc_cfg->bits_per_pixel & 0xf); > > > > > > You did not add linux/bug.h back, presumably because Dmitry added > > > another use of WARN_ON_ONCE to this file in a previous series and it > > > compiles fine as the definition trickles in via another header? > > > > Yep, this compiles fine without any error or warning. > > Yes it does, just curious (CC Dmitry) if that is expected/intended: I am > not familiar enough with the current header includes to say for sure. > > Dmitry seemed to rely on it already being available in > https://git.kernel.org/torvalds/c/2b470e5531f57c1b9bfa129cca0ee17a2ecd2183 I think I did not care about including <linux/bug.h> I checked that current set of headers provides WARN_ON_ONCE, that's all. > but that could have been an oversight? > > - Marijn -- With best wishes Dmitry
