On 24/05/2023 20:02, Conor Dooley wrote: > Hey Caleb, > > On Wed, May 24, 2023 at 06:38:52PM +0100, Caleb Connolly wrote: >> Document the new pmi8998 charger bindings > > This commit message looks a bit odd compared to the contents of the > diff. Did you forget to git add something? Well, it's not my finest commit message... The binding is in the series linked in the cover letter (or [1]), I missed this addition when sending that. Would it be better to just squash this patch into the bindings and respin the other series? [1]: https://lore.kernel.org/linux-arm-msm/20230524-pmi8998-charger-v8-0-b87ffcd9864d@xxxxxxxxxx/ > > Cheers, > Conor. > >> >> Signed-off-by: Caleb Connolly <caleb.connolly@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> index 36de335a33aa..44590dc112be 100644 >> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml >> @@ -133,6 +133,7 @@ patternProperties: >> oneOf: >> - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml# >> - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml# >> + - $ref: /schemas/power/supply/qcom,pmi8998-charger.yaml# >> >> "gpio@[0-9a-f]+$": >> type: object >> >> -- >> 2.40.1 >> -- // Caleb (they/them)