Re: [PATCH v2 6/7] drm/msm/dpu: drop temp variable from dpu_encoder_phys_cmd_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>, Rob Clark <robdclark@xxxxxxxxx>, Sean Paul <sean@xxxxxxxxxx>
Subject: Re: [PATCH v2 6/7] drm/msm/dpu: drop temp variable from dpu_encoder_phys_cmd_init()
From: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
Date: Mon, 22 May 2023 15:38:02 -0700
Cc: Stephen Boyd <swboyd@xxxxxxxxxxxx>, David Airlie <airlied@xxxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, Bjorn Andersson <andersson@xxxxxxxxxx>, <linux-arm-msm@xxxxxxxxxxxxxxx>, <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, <freedreno@xxxxxxxxxxxxxxxxxxxxx>
In-reply-to: <20230519023855.3840907-7-dmitry.baryshkov@linaro.org>
References: <20230519023855.3840907-1-dmitry.baryshkov@linaro.org> <20230519023855.3840907-7-dmitry.baryshkov@linaro.org>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0



On 5/18/2023 7:38 PM, Dmitry Baryshkov wrote:

There is no need to assign a result to temp varable just to return it
two lines below. Drop the temporary variable.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---


Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>

References:
- [PATCH v2 0/7] drm/msm/dpu: simplify DPU encoder init
  - From: Dmitry Baryshkov
- [PATCH v2 6/7] drm/msm/dpu: drop temp variable from dpu_encoder_phys_cmd_init()
  - From: Dmitry Baryshkov

Prev by Date: Re: [PATCH v3] drm/msm/dp: enable HDP plugin/unplugged interrupts at hpd_enable/disable
Next by Date: Re: [PATCH RFC 06/10] drm/panel/samsung-sofef01: Add panel driver for Sony Xperia 5 / 10 II
Previous by thread: [PATCH v2 6/7] drm/msm/dpu: drop temp variable from dpu_encoder_phys_cmd_init()
Next by thread: [PATCH v2 7/7] drm/msm/dpu: simplify dpu_encoder_phys_wb_init()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]