On 2023-05-21 22:22:28, Dmitry Baryshkov wrote:
> This callback has been unused since the driver being added. Drop it now.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7 -------
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 3 ---
> 2 files changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 1dc5dbe58572..c771383446f2 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -2115,7 +2115,6 @@ DEFINE_SHOW_ATTRIBUTE(_dpu_encoder_status);
> static int _dpu_encoder_init_debugfs(struct drm_encoder *drm_enc)
> {
> struct dpu_encoder_virt *dpu_enc = to_dpu_encoder_virt(drm_enc);
> - int i;
>
> char name[DPU_NAME_SIZE];
>
> @@ -2134,12 +2133,6 @@ static int _dpu_encoder_init_debugfs(struct drm_encoder *drm_enc)
> debugfs_create_file("status", 0600,
> dpu_enc->debugfs_root, dpu_enc, &_dpu_encoder_status_fops);
>
> - for (i = 0; i < dpu_enc->num_phys_encs; i++)
> - if (dpu_enc->phys_encs[i]->ops.late_register)
> - dpu_enc->phys_encs[i]->ops.late_register(
> - dpu_enc->phys_encs[i],
> - dpu_enc->debugfs_root);
> -
> return 0;
> }
> #else
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h
> index 1d434b22180d..9e29079a6fc4 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h
> @@ -63,7 +63,6 @@ struct dpu_encoder_phys;
> /**
> * struct dpu_encoder_phys_ops - Interface the physical encoders provide to
> * the containing virtual encoder.
> - * @late_register: DRM Call. Add Userspace interfaces, debugfs.
> * @prepare_commit: MSM Atomic Call, start of atomic commit sequence
> * @is_master: Whether this phys_enc is the current master
> * encoder. Can be switched at enable time. Based
> @@ -93,8 +92,6 @@ struct dpu_encoder_phys;
> */
>
> struct dpu_encoder_phys_ops {
> - int (*late_register)(struct dpu_encoder_phys *encoder,
> - struct dentry *debugfs_root);
> void (*prepare_commit)(struct dpu_encoder_phys *encoder);
> bool (*is_master)(struct dpu_encoder_phys *encoder);
> void (*atomic_mode_set)(struct dpu_encoder_phys *encoder,
> --
> 2.39.2
>
