Re: [PATCH 2/2] drm/msm/dpu: remove CRTC frame event callback registration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/01/2023 02:49, Abhinav Kumar wrote:


On 1/2/2023 7:47 AM, Dmitry Baryshkov wrote:
The frame event callback is always set to dpu_crtc_frame_event_cb() (or
to NULL) and the data is always either the CRTC itself or NULL
(correpondingly). Thus drop the event callback registration, call the
dpu_crtc_frame_event_cb() directly and gate on the dpu_enc->crtc
assigned using dpu_encoder_assign_crtc().

I suggest you wait till we sort out the PSR series for this, especially this patch https://patchwork.freedesktop.org/patch/515787/

There is going to be some change in this code when PSR is pushed again sometime early next week because PSR will touch the crtc assignment code (dpu_enc->crtc),

Based on how we all like that patch, we can get back to this one as this one is a minor cleanup.

As the PSR series have landed, I'd like to point to this patch again.



Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c    | 17 +--------
  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h    | 14 +++++++
  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 41 +++------------------
  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 10 -----
  drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h   |  4 --
  5 files changed, 21 insertions(+), 65 deletions(-)


--
With best wishes
Dmitry




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux