On 15/05/2023 12:40, Tom Rix wrote:
smatch reports drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c:323:29: warning: symbol 'pm8150b_typec_res' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix <trix@xxxxxxxxxx> --- drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c index 191458ce4a06..937e855a6c4c 100644 --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c @@ -320,7 +320,7 @@ static struct pmic_typec_port_resources pm8150b_port_res = { .nr_irqs = 7, };-struct pmic_typec_resources pm8150b_typec_res = {+static struct pmic_typec_resources pm8150b_typec_res = { .pdphy_res = &pm8150b_pdphy_res, .port_res = &pm8150b_port_res, };
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
