On Fri, May 12, 2023 at 03:36:32PM +0300, Abel Vesa wrote:
> The following error was reported when building x86_64 allmodconfig:
>
> error: the following would cause module name conflict:
> drivers/soc/qcom/ice.ko
> drivers/net/ethernet/intel/ice/ice.ko
>
> Seems the 'ice' module name is already used by some Intel ethernet
> driver, so lets rename the Qualcomm Inline Crypto Engine (ICE) from
> 'ice' to 'qcom_ice' to avoid any kind of errors/confusions.
>
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Fixes: 2afbf43a4aec ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver")
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> ---
>
> Changes since v1:
> * changed filename from qcom-ice.c to qcom_ice.c (with underscore)
> to be in line with other Qcom SoC drivers.
>
> drivers/soc/qcom/Makefile | 2 +-
> drivers/soc/qcom/{ice.c => qcom_ice.c} | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename drivers/soc/qcom/{ice.c => qcom_ice.c} (100%)
I'd also prefer that the filename stayed ice.c and just the module was renamed,
given that this is already in the drivers/soc/qcom/ directory.
- Eric
