On Wed, May 10, 2023 at 08:30:23PM +0530, Rohit Agarwal wrote: > Remove the msm_function struct to reuse the generic pinfunction > struct. Also, define a generic PINFUNCTION macro that can be used across > qcom target specific pinctrl files to avoid code repetition. > Looks nice! No need to carry our own structs for things that has made it into the framework. Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx> But, ipq9574.c has made it into linux-next now, so this breaks the build of that driver. So please update this patch. And please send the two refactoring patches on their own, followed by the SDX75 based on that, so we can get those merged quickly, before any other impediments are introduced. Regards, Bjorn
