Re: [PATCH 4/6] dt-bindings: sram: qcom,ocmem: Add msm8226 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 9.05.2023 18:44, Luca Weiss wrote:
> On Montag, 8. Mai 2023 09:39:22 CEST Konrad Dybcio wrote:
>> On 7.05.2023 11:12, Luca Weiss wrote:
>>> Add the compatible for the OCMEM found on msm8226 which compared to
>>> msm8974 only has a core clock and no iface clock.
>>>
>>> Signed-off-by: Luca Weiss <luca@xxxxxxxxx>
>>> ---
>>>
>>>  Documentation/devicetree/bindings/sram/qcom,ocmem.yaml | 6 +++++-
>>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
>>> b/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml index
>>> 4bbf6db0b6bd..515f0d8ec641 100644
>>> --- a/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
>>> +++ b/Documentation/devicetree/bindings/sram/qcom,ocmem.yaml
>>> @@ -15,7 +15,9 @@ description: |
>>>
>>>  properties:
>>>    compatible:
>>> -    const: qcom,msm8974-ocmem
>>> +    enum:
>>> +      - qcom,msm8226-ocmem
>>> +      - qcom,msm8974-ocmem
>>
>> Any chance you could read the revision field on both and add comments
>> like:
>>
>> - qcom,msm8974-ocmem # vX.Y
> 
> Do you mean the OCMEM_REG_HW_VERSION register?
Yep

It's currently not read in the 
> driver so no idea what the value is - without adding some code.
Would be appreciated!

Konrad
> 
>>
>>>    reg:
>>>      items:
>>> @@ -28,11 +30,13 @@ properties:
>>>        - const: mem
>>>    
>>>    clocks:
>>> +    minItems: 1
>>>
>>>      items:
>>>        - description: Core clock
>>>        - description: Interface clock
>>
>> allOf: if: properties: compatible: 8974 / then: clock(s|-names): minItems: 2
> 
> Sure, can update
> 
>>
>> Konrad
>>
>>>    clock-names:
>>> +    minItems: 1
>>>
>>>      items:
>>>        - const: core
>>>        - const: iface
> 
> 
> 
> 



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux