Re: [PATCH] soc: qcom: ramp_controller: Improve error message for failure in .remove()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Sat, Apr 15, 2023 at 10:18:48PM +0200, Uwe Kleine-König wrote:
> When a platform_driver's .remove() callback returns an error, the driver
> core emits
> 
> 	remove callback returned a non-zero value. This will be ignored.
> 
> . Replace this by a more specific error message. Then convert to
> .remove_new() which is equivalent to returning zero unconditionally in
> .remove(). See commit 5c5a7680e67b ("platform: Provide a remove callback
> that returns no value") for its rationale.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
>  drivers/soc/qcom/ramp_controller.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

This patch didn't make it into mainline as of v6.4-rc1 and isn't in next
either. Any volunteer to pick it up? The previous patches to this driver
went in via Bjorn Andersson?!

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux