On 08/05/2023 10:55, Konrad Dybcio wrote:
On 7.05.2023 19:53, Dmitry Baryshkov wrote:The mdp_clk_src clock should not be turned off. Instead it should be 'parked' to the XO, as most of other mdp_clk_src clocks. Fix that by using the clk_rcg2_shared_ops. Fixes: d8b212014e69 ("clk: qcom: Add support for MSM8974's multimedia clock controller (MMCC)") Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> ---I am inclined to think it's true, however I can't see any evidence of this being done on the vendor kernel.. I am however not a licensed archaeologist so I might have missed it.. Hence I'll do:
I have been observing the 'clock stuck at off' without this change. The warning goes away with this patch. Thus I suppose it is correct.
Acked-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konraddrivers/clk/qcom/mmcc-msm8974.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c index 4273fce9a4a4..aa29c79fcd55 100644 --- a/drivers/clk/qcom/mmcc-msm8974.c +++ b/drivers/clk/qcom/mmcc-msm8974.c @@ -485,7 +485,7 @@ static struct clk_rcg2 mdp_clk_src = { .name = "mdp_clk_src", .parent_data = mmcc_xo_mmpll0_dsi_hdmi_gpll0, .num_parents = ARRAY_SIZE(mmcc_xo_mmpll0_dsi_hdmi_gpll0), - .ops = &clk_rcg2_ops, + .ops = &clk_rcg2_shared_ops, }, };
-- With best wishes Dmitry
