Re: [PATCH v3] drm/msm/dpu: drop unused SSPP sub-block information

[Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>]

On 4/29/2023 2:25 PM, Dmitry Baryshkov wrote:
> The driver  doesn't support hsic/memcolor and pcc SSPP subblocks.
> Drop corresponding definitions.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
>
> Changes since v2:
> - Fixed commit message to remove igc block mention.
>
> Changes since v1:
>   - Rebased on top of https://patchwork.freedesktop.org/patch/534725/?series=117130&rev=1
>
> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> index 69d1f1e59db1..b2831b45ac64 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> @@ -380,9 +380,6 @@ struct dpu_caps {
>    * @qseed_ver: qseed version
>    * @scaler_blk:
>    * @csc_blk:
> - * @hsic:
> - * @memcolor:
> - * @pcc_blk:

pcc_blk is still there. So this should be dropped. Once that is fixed,

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>

>    * @format_list: Pointer to list of supported formats
>    * @num_formats: Number of supported formats
>    * @virt_format_list: Pointer to list of supported formats for virtual planes
> @@ -399,9 +396,6 @@ struct dpu_sspp_sub_blks {
>   	u32 qseed_ver;
>   	struct dpu_scaler_blk scaler_blk;
>   	struct dpu_pp_blk csc_blk;
> -	struct dpu_pp_blk hsic_blk;
> -	struct dpu_pp_blk memcolor_blk;
> -	struct dpu_pp_blk pcc_blk;
>   
>   	const u32 *format_list;
>   	u32 num_formats;