On Fri, Jun 05, 2015 at 10:57:01AM +0100, Matt Fleming wrote: > [ Cc'ing Boris and Tony. Folks original patch is here, > https://lkml.kernel.org/r/1433185940-24770-4-git-send-email-zjzhang@xxxxxxxxxxxxxx ] > > On Mon, 01 Jun, at 12:12:20PM, Jonathan (Zhixiong) Zhang wrote: > > From: "Jonathan (Zhixiong) Zhang" <zjzhang@xxxxxxxxxxxxxx> > > > > With ACPI APEI firmware first handling, generic hardware error > > record is updated by firmware in GHES memory region. When firmware > > updated GHES memory region in DDR without going through cache, What is DDR? I think this needs to be clarified first before we go any further. I picked up on the sidelines that this might be arm64-specific stuff. If so, your approach is wrong: you're merging efi_* facilities from x86 and ia64 into generic efi ones but then doing CONFIG_EFI ifdeffery in GHES. What you should do instead is have arch-specific: ghes_ioremap_pfn_irq() ghes_iounmap_irq() ... and whatever else functionality which is different on your arch and which get called from the generic ghes.c driver. In the arch-specific ones you can go wild with the ifdeffery and whatnot is needed on that specific arch. Something like that, at least. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
