Re: [PATCH] drm/msm/dpu: drop the regdma configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Whoops, looks like I wrongly lost all the cc's when importing b4-am's
mbx file which is just a patch with a few but not all email headers.
Cc'ing everyone on this occasion with my review.

On 2023-04-20 23:33:07, Marijn Suijten wrote:
> On 2023-04-20 23:07:42, Dmitry Baryshkov wrote:
> > The regdma is currently not used by the current driver. We have no way
> 
> Nit: 2x current
> 
> > to practically verify that the regdma is described correctly. Drop it
> > now.
> > 
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> 
> Do we need to keep the `regdma` range that is `ioremap`ed in
> `dpu_kms.c`?  Only msm8998-dpu allows it in the bindings anyway.
> 
> > ---
> >  .../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h   |  2 -
> >  .../msm/disp/dpu1/catalog/dpu_4_0_sdm845.h    |  2 -
> >  .../msm/disp/dpu1/catalog/dpu_5_0_sm8150.h    |  2 -
> >  .../msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h   |  2 -
> >  .../msm/disp/dpu1/catalog/dpu_6_0_sm8250.h    |  2 -
> >  .../msm/disp/dpu1/catalog/dpu_6_2_sc7180.h    |  2 -
> >  .../msm/disp/dpu1/catalog/dpu_7_0_sm8350.h    |  2 -
> >  .../msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h  |  2 -
> >  .../msm/disp/dpu1/catalog/dpu_8_1_sm8450.h    |  2 -
> >  .../msm/disp/dpu1/catalog/dpu_9_0_sm8550.h    |  2 -
> >  .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c    | 40 -------------------
> >  .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h    | 18 ---------
> >  12 files changed, 78 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h
> > index 2b3ae84057df..aa923fb2ebcb 100644
> > --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h
> > @@ -195,8 +195,6 @@ const struct dpu_mdss_cfg dpu_msm8998_cfg = {
> >  	.intf = msm8998_intf,
> >  	.vbif_count = ARRAY_SIZE(msm8998_vbif),
> >  	.vbif = msm8998_vbif,
> > -	.reg_dma_count = 0,
> > -	.perf = &msm8998_perf_data,
> 
> Don't think you intended to remove the perf data?  There's no dma_cfg
> member because the count is zero.

- Marijn



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux