On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> Regulators is not a bus, so drop incomplete simple-bus usage to fix dtbs
> W=1 warnings:
>
> Warning (simple_bus_reg): /regulators/regulator-fixed: missing or empty reg/ranges property
> Warning (simple_bus_reg): /regulators/xc622a331mrg: missing or empty reg/ranges property
> Warning (simple_bus_reg): /regulators/nds332p: missing or empty reg/ranges property
> Warning (simple_bus_reg): /regulators/txb0104rgyr: missing or empty reg/ranges property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../arm/boot/dts/qcom-apq8060-dragonboard.dts | 80 +++++++++----------
> 1 file changed, 38 insertions(+), 42 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> index 8e4b61e4d4b1..e830cb2395aa 100644
> --- a/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8060-dragonboard.dts
> @@ -18,50 +18,46 @@ chosen {
> stdout-path = "serial0:115200n8";
> };
>
> - regulators {
> - compatible = "simple-bus";
> -
> - /* Main power of the board: 3.7V */
> - vph: regulator-fixed {
> - compatible = "regulator-fixed";
> - regulator-min-microvolt = <3700000>;
> - regulator-max-microvolt = <3700000>;
> - regulator-name = "VPH";
> - regulator-type = "voltage";
> - regulator-always-on;
> - regulator-boot-on;
> - };
> -
> - /* GPIO controlled ethernet power regulator */
> - dragon_veth: xc622a331mrg {
> - compatible = "regulator-fixed";
> - regulator-name = "XC6222A331MR-G";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - vin-supply = <&vph>;
> - gpio = <&pm8058_gpio 40 GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> - pinctrl-names = "default";
> - pinctrl-0 = <&dragon_veth_gpios>;
> - regulator-always-on;
> - };
> + /* Main power of the board: 3.7V */
> + vph: regulator-fixed {
> + compatible = "regulator-fixed";
> + regulator-min-microvolt = <3700000>;
> + regulator-max-microvolt = <3700000>;
> + regulator-name = "VPH";
> + regulator-type = "voltage";
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + /* GPIO controlled ethernet power regulator */
> + dragon_veth: xc622a331mrg {
These names could also be fixed up, but that's for another day..
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Konrad
> + compatible = "regulator-fixed";
> + regulator-name = "XC6222A331MR-G";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + vin-supply = <&vph>;
> + gpio = <&pm8058_gpio 40 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + pinctrl-names = "default";
> + pinctrl-0 = <&dragon_veth_gpios>;
> + regulator-always-on;
> + };
>
> - /* VDDvario fixed regulator */
> - dragon_vario: nds332p {
> - compatible = "regulator-fixed";
> - regulator-name = "NDS332P";
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> - vin-supply = <&pm8058_s3>;
> - };
> + /* VDDvario fixed regulator */
> + dragon_vario: nds332p {
> + compatible = "regulator-fixed";
> + regulator-name = "NDS332P";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + vin-supply = <&pm8058_s3>;
> + };
>
> - /* This is a levelshifter for SDCC5 */
> - dragon_vio_txb: txb0104rgyr {
> - compatible = "regulator-fixed";
> - regulator-name = "Dragon SDCC levelshifter";
> - vin-supply = <&pm8058_l14>;
> - regulator-always-on;
> - };
> + /* This is a levelshifter for SDCC5 */
> + dragon_vio_txb: txb0104rgyr {
> + compatible = "regulator-fixed";
> + regulator-name = "Dragon SDCC levelshifter";
> + vin-supply = <&pm8058_l14>;
> + regulator-always-on;
> };
>
> /*
