Quoting Taniya Das (2023-04-16 21:40:48) > Hi Dmitry, > > Thanks for the comments. > > > On 3/3/2023 4:14 PM, Dmitry Baryshkov wrote: > > On Fri, 3 Mar 2023 at 11:30, Taniya Das <quic_tdas@xxxxxxxxxxx> wrote: > >> > >> Introduce start_index to handle invalid index error > >> seen when there are two clock descriptors assigned > >> to the same clock controller. > > > > Please provide details of the exact case that you are trying to solve > > (this might go to the cover letter). I think the commit message is > > slightly misleading here. Are you trying to add error messages or to > > prevent them from showing up? > > > > We are trying to avoid error messages from showing up. > > > I'm asking because error messages do not seem to correspond to patch > > 2. You add start_index to make the kernel warn for the clock indices > > less than LPASS_AUDIO_CC_CDIV_RX_MCLK_DIV_CLK_SRC = 4, while quoted > > messages show indices 5,6,7. > > > > Right, we want the kernel to warn if the clock index is less than > start_index, along with that we also want to handle the case where > num_rclks is uninitialized because of same clock descriptor being > assigned to two clock controllers. The start_index should be 0.
