On 07/04/2023 18:23, Doug Anderson wrote: > Hi, > > On Fri, Apr 7, 2023 at 8:14 AM Nikita Travkin <nikita@xxxxxxx> wrote: >> >> Acer Aspire 1 is a laptop based on sc7180. Document it's compatible. >> >> Signed-off-by: Nikita Travkin <nikita@xxxxxxx> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- >> Changes in v2: >> - Merge with IDP (Krzysztof) >> --- >> Documentation/devicetree/bindings/arm/qcom.yaml | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >> index f8d29b65f28b..db97a61e8ccb 100644 >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >> @@ -367,9 +367,9 @@ properties: >> - qcom,qru1000-idp >> - const: qcom,qru1000 >> >> - - description: Qualcomm Technologies, Inc. SC7180 IDP >> - items: >> + - items: >> - enum: >> + - acer,aspire1 >> - qcom,sc7180-idp >> - const: qcom,sc7180 > > If Krzysztof is happy then I have no real objections here. That being > said, I personally would have updated the description to be more > generic and not say "IDP" anymore. Something like "Non-Chromebook > sc7180 boards". I am fine with both - dropping the description or changing it to something meaningful. Best regards, Krzysztof
