On Sat, May 16, 2015 at 05:31:02AM -0700, Srinivas Kandagatla wrote: > Thankyou for reviewing the v1 patches, here is the v2 patchset after > incorporating review comments and testing on Storm Board. > This patchset adds apq8016 audio support into lpass driver. Existing > Lpass driver can not be used as-it-is for apq8016 as it contains code > specific to ipq806x. Also the driver only supports single i2s port, > single dma channel and single bitclk control. > > APQ8016 has 4 MI2S( Primary, Secondary, Tertiary, Quaternary) which can be > routed > to internal wcd codec or external codecs. This routing is controlled by 2 > mux > registers. > > This patch series firstly re-organizes the lpass driver such that the SOC > specific bits are moved away from the driver. And secondly the SOC > specifics > are now passed as lpass variant data which would include various register > offsets, dma channel allocations and SOC specific clock handling. > > Finally the last few patchs add apq8016 lpass and machine driver. > > All these patches are tested for HDMI audio via adv7533 bridge and Analog > audio > on APQ8016-SBC, msm8916-mtp boards and Kenneth tested this patchset on > ipq806x Storm board too. Other than the two comments on patches 5 and 6, everything else looks fine to me. Acked-by: Kenneth Westfield <kwestfie@xxxxxxxxxxxxxx> -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
