On 06/04/2023 20:45, Bjorn Andersson wrote: > On Tue, Mar 21, 2023 at 02:24:22PM +0530, Varadarajan Narayanan wrote: >> diff --git a/drivers/clk/qcom/gcc-ipq9574.c b/drivers/clk/qcom/gcc-ipq9574.c > [..] >> diff --git a/include/dt-bindings/clock/qcom,ipq9574-gcc.h b/include/dt-bindings/clock/qcom,ipq9574-gcc.h >> index c89e96d..96b7c0b 100644 >> --- a/include/dt-bindings/clock/qcom,ipq9574-gcc.h >> +++ b/include/dt-bindings/clock/qcom,ipq9574-gcc.h >> @@ -214,4 +214,6 @@ >> #define GCC_SNOC_PCIE1_1LANE_S_CLK 205 >> #define GCC_SNOC_PCIE2_2LANE_S_CLK 206 >> #define GCC_SNOC_PCIE3_2LANE_S_CLK 207 >> +#define GCC_USB0_PIPE_CLK 208 >> +#define GCC_USB0_SLEEP_CLK 209 > > Please split out the dt binding/include change in a separate patch, to > better facilitate picking both the clock and dts patch for the same > kernel version. Uh, bindings must be split to their own patch as they are exported from kernel repo. Best regards, Krzysztof