On 5.04.2023 08:41, Dikshita Agarwal wrote: > > On 4/4/2023 11:54 PM, Konrad Dybcio wrote: >> >> On 4.04.2023 08:17, Dikshita Agarwal wrote: >>> Use firmware version based check to assign correct >>> device address for EOS buffer to fix the EOS handling >>> with different firmware version. >>> >>> Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx> >>> Signed-off-by: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx> >>> Signed-off-by: Viswanath Boma <quic_vboma@xxxxxxxxxxx> >>> Tested-by: Nathan Hebert <nhebert@xxxxxxxxxxxx> >>> --- >> Does it only concern fw 1.0.xx? >> >> Konrad > > that's right. > > changes were made in later firmware (newer than 1.0.87) to > > make the behavior generic across all supported SOCs. > > Thanks, OK Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> Konrad > > Dikshita > >>> drivers/media/platform/qcom/venus/vdec.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c >>> index f0394b9..c59b34f 100644 >>> --- a/drivers/media/platform/qcom/venus/vdec.c >>> +++ b/drivers/media/platform/qcom/venus/vdec.c >>> @@ -545,7 +545,7 @@ vdec_decoder_cmd(struct file *file, void *fh, struct v4l2_decoder_cmd *cmd) >>> fdata.buffer_type = HFI_BUFFER_INPUT; >>> fdata.flags |= HFI_BUFFERFLAG_EOS; >>> - if (IS_V6(inst->core)) >>> + if (IS_V6(inst->core) && is_fw_rev_or_older(inst->core, 1, 0, 87)) >>> fdata.device_addr = 0; >>> else >>> fdata.device_addr = 0xdeadb000;
