On 4/1/23 17:18, Uwe Kleine-König wrote: > Hello, > > this series adapts the platform drivers below drivers/mtd/nand to use the > .remove_new() callback. Compared to the traditional .remove() callback > .remove_new() returns no value. This is a good thing because the driver core > doesn't (and cannot) cope for errors during remove. The only effect of a > non-zero return value in .remove() is that the driver core emits a warning. The > device is removed anyhow and an early return from .remove() usually yields a > resource leak. > > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. > > As all drivers already return 0 in their .remove callback, they can be > converted trivially. > I'd make a single patch per subsystem for trivial changes, but I don't mind having them split per driver either: Acked-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>