On Mon, 3 Apr 2023 at 13:35, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>
>
>
> On 2.04.2023 11:51, Krzysztof Kozlowski wrote:
> > On 02/04/2023 00:08, Dmitry Baryshkov wrote:
> >> Supporting SIDs greater than 9 required additional handling in order to
> >> properly generatae hex values. Apply this customization to pm8150.dtsi.
> >>
> >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> >> ---
> >> arch/arm64/boot/dts/qcom/pm8150.dtsi | 16 ++++++++--------
> >> arch/arm64/boot/dts/qcom/pmic-dyn-footer.dtsi | 6 ++++++
> >> arch/arm64/boot/dts/qcom/pmic-dyn-header.dtsi | 6 ++++++
> >> 3 files changed, 20 insertions(+), 8 deletions(-)
> >>
> >
> >> diff --git a/arch/arm64/boot/dts/qcom/pmic-dyn-footer.dtsi b/arch/arm64/boot/dts/qcom/pmic-dyn-footer.dtsi
> >> index 83a2bada48ff..f3743ef3aa13 100644
> >> --- a/arch/arm64/boot/dts/qcom/pmic-dyn-footer.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/pmic-dyn-footer.dtsi
> >> @@ -11,6 +11,12 @@
> >>
> >> #undef NODE
> >>
> >> +#undef HEX
> >> +#undef _HEX
> >> +
> >> +#undef PMIC_SID_HEX
> >> +#undef PMIC_SID1_HEX
> All decimal numbers can be represented as hex numbers..
> Is there any point to keeping them separate?
Yes, to have pmic@c rather than pmic@12 for USID = 12 = 0xc.
>
> Konrad
> >> +
> >> #undef PMIC_SID
> >> #undef PMIC_SID1
> >> #undef PMIC_LABEL
> >
> > Same comment as for previous patches - all undefs must be gone.
This means that we can not include two copies of the same PMIC (which
do have on both platforms).
> >
> > Maybe I should not have acked all these changes customized SID ("include
> > sid into defines") because it looks like it opened can of worms.
I think this can of worms is still better than imperfect duplication.
--
With best wishes
Dmitry
