On Sat, 1 Apr 2023 at 22:40, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On Sat, 1 Apr 2023 at 18:49, Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> wrote: > > > > Changes since v3: > > ----------------- > > - v3 can be seen here: https://lore.kernel.org/linux-arm-msm/20221215094532.589291-4-bhupesh.sharma@xxxxxxxxxx/ > > - Fixed v4 as per the downstream driver code: https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/bengal-usb.dtsi#296 > > - As per the downstream code, the qmp phy on this SoC is similar to the > > SM8150 qmp phy and is indeed not a qmp-dp combo phy. > > Nit: sm8150 has both USB UNI PHY and USB+DP combo PHYs, so this note > is incorrect. I think I should have clarified a bit more here, but the complete context is that for the previous versions of this patch there were conversations on irc as to whether this was a 'qcom,usb-ssphy-qmp-usb3-or-dp' or a 'qcom,usb-ssphy-qmp-dp-combo' as per downstream code and hardware documentation. But after a careful look at the <https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/bengal-usb.dtsi#296> documentation it appears that this indeed is a 'qcom,usb-ssphy-qmp-usb3-or-dp phy and not a 'dp-combo' phy. Thanks, Bhupesh > > > > This patchset adds the support for USB SS qmp phy for Qualcomm SM6115 > > SoC. > > > > Bhupesh Sharma (2): > > dt-bindings: phy: qcom,qmp-usb: Fix phy subnode for SM6115 & QCM2290 > > USB3 PHY > > arm64: dts: qcom: sm6115: Add USB SS qmp phy node > > > > .../phy/qcom,msm8996-qmp-usb3-phy.yaml | 4 +-- > > .../boot/dts/qcom/sm4250-oneplus-billie2.dts | 3 ++ > > arch/arm64/boot/dts/qcom/sm6115.dtsi | 36 +++++++++++++++++-- > > .../boot/dts/qcom/sm6115p-lenovo-j606f.dts | 3 ++ > > 4 files changed, 42 insertions(+), 4 deletions(-) > > > > -- > > 2.38.1 > > > > > -- > With best wishes > Dmitry
