On Tue, Mar 28, 2023 at 10:31:16AM +0200, Pavel Machek wrote:
> On Mon 2023-03-27 16:10:31, Christian Marangi wrote:
> > From: Andrew Lunn <andrew@xxxxxxx>
> >
> > The WAN port of the 370-RD has a Marvell PHY, with one LED on
> > the front panel. List this LED in the device tree.
>
> > @@ -135,6 +136,19 @@ &mdio {
> > pinctrl-names = "default";
> > phy0: ethernet-phy@0 {
> > reg = <0>;
> > + leds {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + led@0 {
> > + reg = <0>;
> > + label = "WAN";
> > + color = <LED_COLOR_ID_WHITE>;
> > + function = LED_FUNCTION_LAN;
> > + function-enumerator = <1>;
> > + linux,default-trigger = "netdev";
> > + };
>
> /sys/class/leds/WAN is not acceptable.
As i said here, that is not what it gets called:
https://lore.kernel.org/netdev/aa2d0a8b-b98b-4821-9413-158be578e8e0@xxxxxxx/T/#m6c72bd355df3fcf8babc0d01dd6bf2697d069407
> It can be found in /sys/class/leds/f1072004.mdio-mii:00:WAN. But when
> we come to using it for ledtrig-netdev, the user is more likely to follow
> /sys/class/net/eth0/phydev/leds/f1072004.mdio-mii\:00\:WAN/
Is that acceptable?
What are the acceptance criteria?
Andrew
