On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote:
> Fixes the following DT bindings check error:
Is that because idle-state-name and local-timer-stop should not be
defined for domain-idle-states or are you just clearing out the
dtbs_check warning?
According to cpu-capacity.txt local-timer-stop seems to have been a
property relevant for clusters in the past, was this a mistake in the
binding or did something change when this was moved to
domain-idle-states?
Regards,
Bjorn
> domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes:
> 'pinctrl-[0-9]+'
> domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes:
> 'pinctrl-[0-9]+'
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 78fb65bd15cc..ff55fcfdd676 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -255,22 +255,18 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 {
> domain-idle-states {
> CLUSTER_SLEEP_0: cluster-sleep-0 {
> compatible = "domain-idle-state";
> - idle-state-name = "cluster-l3-off";
> arm,psci-suspend-param = <0x41000044>;
> entry-latency-us = <1050>;
> exit-latency-us = <2500>;
> min-residency-us = <5309>;
> - local-timer-stop;
> };
>
> CLUSTER_SLEEP_1: cluster-sleep-1 {
> compatible = "domain-idle-state";
> - idle-state-name = "cluster-power-collapse";
> arm,psci-suspend-param = <0x4100c344>;
> entry-latency-us = <2700>;
> exit-latency-us = <3500>;
> min-residency-us = <13959>;
> - local-timer-stop;
> };
> };
> };
>
> --
> 2.34.1
>
