On Fri, 24 Mar 2023 at 09:23, Johan Hovold <johan@xxxxxxxxxx> wrote:
>
> On Fri, Mar 24, 2023 at 03:17:52AM +0300, Dmitry Baryshkov wrote:
> > All PCIe PHYs on sc8180x platform have 2 lanes, so change the number of
> > lanes to 2.
> >
> > Fixes: 94a407cc17a4 ("phy: qcom-qmp: create copies of QMP PHY driver")
>
> This is not the right fixes tag either. This should have been
>
> Fixes: f839f14e24f2 ("phy: qcom-qmp: Add sc8180x PCIe support")
>
> Should this also be backported (i.e. should you add a stable tag)?
Maybe, but it's not that important. We don't have corresponding DT
bits, so it seems not that urgent.
>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> > index d580f3d3e221..c95bf7ec2abe 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-pcie.c
> > @@ -2193,7 +2193,7 @@ static const struct qmp_phy_cfg msm8998_pciephy_cfg = {
> > };
> >
> > static const struct qmp_phy_cfg sc8180x_pciephy_cfg = {
> > - .lanes = 1,
> > + .lanes = 2,
> >
> > .tbls = {
> > .serdes = sc8180x_qmp_pcie_serdes_tbl,
>
> Johan
--
With best wishes
Dmitry
