On Fri, Mar 24, 2023 at 02:37:15AM +0000, Bryan O'Donoghue wrote: > On 24/03/2023 01:13, Jianhua Lu wrote: > >> Can you show the printout of *(pmic_typec->base + TYPEC_SM_STATUS_REG) ? > > [ 17.108819] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: > qcom_pmic_typec_port_set_vbus misc 0x000000cb > > [ 17.118659] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: > qcom_pmic_typec_port_set_vbus sm_status 0x000000b9 > > SM_STAT == 0xb9 => 10111001 When I connect my device to a usb hub with external power supply, it show [ 1495.622026] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: get_cc: misc 0x000000c9 cc1 0x00000002 Rd cc2 0x00000000 Open attached 1 cc=cc2 [ 1495.622383] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: get_cc: misc 0x000000c9 cc1 0x00000002 Rd cc2 0x00000000 Open attached 1 cc=cc2 [ 1495.824637] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: qcom_pmic_typec_set_vbus sm_stat output 0x000000b9 [ 1495.824667] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: qcom_pmic_typec_set_vbus misc 0x000000c9 [ 1495.824685] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: qcom_pmic_typec_set_vbus sm_status 0x000000b9 [ 1495.824739] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: set_cc: currsrc=1 Rp-1.5-180uA mode EN_SRC_ONLY debounce 1 attached 1 cc=cc2 [ 1495.829001] qcom,pmic-typec c440000.spmi:pmic@2:typec@1500: Debounce cc complete I think my device's pm8150b is connected to charger pump but this charger driver hasn't been implement, so can't detect pm8150b_vbus. > > In other words, my hardware gives a clear indication of the appropriate > transition. > > Would appreciate if you could apply the above "patch" > > That said I _am_ included to believe you and to do something about it, I > will downgrade to a warning instead of returning on error in failure to > transition to VSafeVX Your patch is correct. Making it warning let other devices' type-c work normally. I agree with your idea. > > Yeah though I'd appreciate seeing the output of the above patch to see > if there's something we are missing. > > Thanks for your review/time/input > > --- > bod
