On Tue, Mar 21, 2023 at 10:27:55AM -0500, Rob Herring wrote: > On Tue, Mar 21, 2023 at 8:37 AM Johan Hovold <johan@xxxxxxxxxx> wrote: > > On Tue, Mar 21, 2023 at 08:20:55AM -0500, Rob Herring wrote: > > > On Tue, Mar 21, 2023 at 8:17 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > On Mon, 20 Mar 2023 14:57:10 +0100, Johan Hovold wrote: > > > > > Add an 'nvram' pattern property and a reference to the corresponding > > > > > SDAM DT schema. > > > > > > > > > > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > > > > > --- > > > > > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 4 ++++ > > > > > 1 file changed, 4 insertions(+) > > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > > > following warnings. Consider if they are expected or the schema is > > > > incorrect. These may not be new warnings. > > > > > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > > > This will change in the future. > > > > > > > > Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230320135710.1989-4-johan+linaro@xxxxxxxxxx > > > > > > > > > > This is a long list of warnings. Can you all fix some of them before > > > adding on to this binding. > > > > Note that this patch is only making the list of warnings shorter so I > > don't think addressing the remaining issues should block this one. > > How can you tell sorting thru the 100s of warnings? It sounded like a > new feature to me, not a fix for something missing. Anyways, I've > gotten 2 patches today for this binding and I don't see patches for > fixes. Which is a bit surprising because you all generally are fixing > warnings on the QCom stuff. Indeed, it was not obvious and that's why I mentioned it. The SDAM binding has been there since 2020 and 9664a6b54c57 ("dt-bindings: nvmem: add binding for QTI SPMI SDAM") but updating the "parent" pmic binding was apparently overlooked. I'm generally not cleaning up DT checker warnings, but I want to avoid adding new ones as I unknowingly did in this case when enabling the RTC on the X13s. > I didn't really mean to block this one, but I don't really want to see more. Understood. Johan
