On Mon, Mar 20, 2023 at 02:22:12PM +0200, Kalle Valo wrote: > Johan Hovold <johan+linaro@xxxxxxxxxx> writes: > > > Add devicetree bindings for Qualcomm ath11k PCIe devices such as WCN6856 > > for which the calibration data variant may need to be described. > > > > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > > --- > > .../bindings/net/wireless/pci17cb,1103.yaml | 56 +++++++++++++++++++ > > 1 file changed, 56 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml > > I'm confused (as usual), how does this differ from > bindings/net/wireless/qcom,ath11k.yaml? Why we need two .yaml files? Almost none of bindings/net/wireless/qcom,ath11k.yaml applies to WCN6856 when using PCIe (e.g. as most properties are then discoverable). We could try to encode everything in one file, but that would likely just result in a big mess of a schema with conditionals all over. Johan