Re: [PATCH v4 17/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>, linux@xxxxxxxxxxxx, heikki.krogerus@xxxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, andersson@xxxxxxxxxx, robh+dt@xxxxxxxxxx, krzysztof.kozlowski+dt@xxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v4 17/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1
From: "Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx>
Date: Sat, 18 Mar 2023 17:46:22 +0000
Cc: wcheng@xxxxxxxxxxxxxx, caleb.connolly@xxxxxxxxxx, subbaram@xxxxxxxxxxx, jackp@xxxxxxxxxxx, robertom@xxxxxxxxxxxxxxxx
In-reply-to: <6e897b77-671b-2049-4327-631350e8f868@linaro.org>
References: <20230318121828.739424-1-bryan.odonoghue@linaro.org> <20230318121828.739424-18-bryan.odonoghue@linaro.org> <6e897b77-671b-2049-4327-631350e8f868@linaro.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 18/03/2023 13:10, Konrad Dybcio wrote:

+	usb-role-switch;

This could maybe go to the SoC DTSI.. Bjorn, Krzysztof, WDYT?


Eh well I think this is a correct comment.

There's no good reason to have this as board-specific since it is acontroller property. Moreover it only does something when there is a anagent to feed data into it.


arch/arm64/boot/dts/qcom/sc7280.dtsi:				usb-role-switch;

---
bod

References:
- [PATCH v4 00/18] Add Qualcomm PMIC TPCM support
  - From: Bryan O'Donoghue
- [PATCH v4 17/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1
  - From: Bryan O'Donoghue
- Re: [PATCH v4 17/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1
  - From: Konrad Dybcio

Prev by Date: Re: [PATCH v2 4/4] serial: qcom_geni: Use devm_krealloc_array
Next by Date: Re: [PATCH v4 18/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy
Previous by thread: Re: [PATCH v4 17/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1
Next by thread: [PATCH v4 18/18] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [Linux for Sparc] [IETF Annouce] [Security] [Bugtraq] [Linux MIPS] [ECOS] [Asterisk Internet PBX] [Linux API]